Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix : Position of two button #30

Closed
wants to merge 1 commit into from
Closed

Fix : Position of two button #30

wants to merge 1 commit into from

Conversation

GOVINDDIXIT
Copy link
Member

@GOVINDDIXIT GOVINDDIXIT commented Jan 17, 2018 •
edited
Loading

Checklist

  • My branch is up-to-date with the Upstream master branch.
  • I have added necessary documentation (if appropriate)

Changes proposed in this pull request

-update activity_maps_main.xml
-update activity_maps.xml

Screenshots (if appropriate)

android

Link to live demo (if appropriate):

Fixes #21

reverie-ss
reverie-ss approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@reverie-ss reverie-ss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

yashovardhan
yashovardhan requested changes Jan 18, 2018
View reviewed changes
Copy link
Member

@yashovardhan yashovardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squash your commits

@GOVINDDIXIT
Copy link
Member Author

Done

yashovardhan
yashovardhan reviewed Jan 19, 2018
View reviewed changes
Copy link
Member

@yashovardhan yashovardhan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see, since you are changing positions of two buttons, there must be two commits, each containing proper message not like Update a file; it must be like a brief description of your commit within 50 characters 😄

@GOVINDDIXIT
Copy link
Member Author

GOVINDDIXIT commented Jan 19, 2018 •
edited
Loading

Forgive me this time,I will take care about this for upcoming issues 😜

@yashovardhan
Copy link
Member

@GOVINDDIXIT sorry but I'm afraid that's not how it works. Code quality should be maintained, I will update the Wiki Page with the Contribution Guidelines.
They have to be followed, we are a very small organisation and keeping good standards will only help us grow. Hope you understand.

If you contribute to bigger organisations like @coala you'll have to go through various standard checks before your PR's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashovardhan yashovardhan yashovardhan requested changes

@reverie-ss reverie-ss reverie-ss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Position of two buttons
3 participants
@GOVINDDIXIT @yashovardhan @reverie-ss