Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema issue preventing component rendering form in AAT v1 #31

Closed
joe-allen-89 opened this issue Jul 29, 2024 · 1 comment · Fixed by #32
Closed

Schema issue preventing component rendering form in AAT v1 #31

joe-allen-89 opened this issue Jul 29, 2024 · 1 comment · Fixed by #32
Assignees
@joe-allen-89
Labels
bug released

Comments

@joe-allen-89
Copy link
Contributor

Subject of the issue/enhancement/features

Originally raised during v1 testing - https://github.com/cgkineo/adapt-authoring/issues/40

When adding adapt-youtube to a course in AAT the form is unable to render due to below required:

https://github.com/adaptlearning/adapt-youtube/blob/e9fd6fcf660b981d45c8349ac0c553819ba6d4f2/schema/component.schema.json#L10C1-L12C9

Suggest moving required to _media itself to make the source required:

"required": [ "_source"],

Your environment

Steps to reproduce

  • Create a course
  • Try to add adapt-youtube component
@joe-allen-89 joe-allen-89 self-assigned this Jul 29, 2024
joe-allen-89 added a commit that referenced this issue Jul 29, 2024
@joe-allen-89
Fix: "required":"_media" replaced with a more specific "required": "_…
0a031b8 
…source" (fixes #31)
@joe-allen-89 joe-allen-89 mentioned this issue Jul 29, 2024
Merged
@joe-allen-89 joe-allen-89 linked a pull request Jul 29, 2024 that will close this issue
Fix: "required":"_media" replaced with a more specific "required": "_source" (fixes #31) #32
Merged
github-actions bot pushed a commit that referenced this issue Sep 5, 2024
@semantic-release-bot
Chore(release): 3.2.2 [skip ci]
8901501 
## [3.2.2](v3.2.1...v3.2.2) (2024-09-05)

### Fix

* "required":"_media" replaced with a more specific "required": "_source" (fixes #31) (#32) ([b09f6e1](b09f6e1)), closes [#31](#31) [#32](#32)
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024

🎉 This issue has been resolved in version 3.2.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
bug released
Projects
None yet
Milestone
No milestone
1 participant
@joe-allen-89