-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse-mobile-order block class #532
Comments
I don't think these maintain the tab order do they? |
No, the I suppose a JSON option that changes the DOM order would be preferred here? |
Hmm... _reverseChildrenOnDeviceSizes type thing? Not quite sure what would be the best plan. NavigationView has a nice Dom sort algorithm https://github.com/adaptlearning/adapt-contrib-core/blob/89a0421ba06e127bfb0b5825a2bd7e839e06d49b/js/views/navigationView.js#L177 |
It might be a good idea to check that this is an issue with whoever wrote this CSS originally first? |
Looks like @guywillis was involved with that one. Is there a reason we removed the ability to change the DOM order and instead use flexbox? |
Clutching at memory straws but I think it ended up being simpler to do via a custom class than a json property. I'm not opposed to returning to a json property as it's certainly more AAT friendly. |
Subject of the enhancement
It would be useful to have a
reverse-mobile-order
block class that would work similarly to thereverse-desktop-order
desktop class.The text was updated successfully, but these errors were encountered: