Breaking: Adapt buttons overhaul (fixes #469) #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- focus state inherits from hover (as per existing component focus styles) - existing @visited vars are only used by components so grouped with content item
- focus state inherits from hover (as per existing focus styles) - locked state inherits from disabled (as per existing locked styles)
- Replace @btn-ui-color vars with @ui-color vars. Nav, Notify and Drawer btns inherit from their view colours. This sets an extra level of vars to define global ui colors or edit these separately as per existing Vanilla. - rename _buttonStates.less file to _state-mixins.less.
- ui-btn-controls vars added - shared Notify and Drawer btn styles combined into single ui-btn--controls mixin. Replacing .notify-btn-icon mixin.
- set menu item btn vars to inherit from item ui
- item ui locked state added - set .narrative__strapline-icon to inherit from narrative__strapline-btn to reduce additional state declaration styles
… controls and strapline - Narrative strapline icon background color set to transparent to prevent icon background obscuring the btn focus outline
- border-radius added - default drawer item vars represent current drawer styles - margin gives option to display items in a 'button style' - when margin is set, apply border to whole of button (not just bottom)
- drawer item selected state expanded to support aria-current="true" (used by languagepicker which should inherit selected, not disabled styling.
- outline and plain styles added to existing mixins still tbc - TODO and query comments added - border width and color vars added
- outline and plain styles added to existing mixins - border width and color vars added
...used for Hotgraphic controls first/last item
...mixins inherit from their state color var instead
…ming ...changed to 'ui-btn-ctrl-color' for consistency with other color variable naming and consistency with .ui-btn-ctrl;
…ming ...changed to 'ui-btn-ctrl-color' for consistency with other color variable naming and consistency with .ui-btn-ctrl;
- temp button style vars added - naming tbc - drawer item locked state added
- missing item border-width var added - @menu-item-btn-style var name fix - missing btn state mixins added - notify btn style var fix - comments added
- share border-width variable between drawer and notify UI button controls - remove reference to 'color' from border width variables - change reference from 'icon' to 'btn' for nav ui border-width variable for consistency with other nav btn spacing variables - move border-width variables into spacing less - set menu item to inherit its own border-radius variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #469
New
Breaking
@button-icon-color) in favour of new specific button type variables. To prevent a breaking change, these could be re-added and set to inherit a new variable for backwards compatibility (if desired).@ui-coloror@item-ui-colorwould be appropriate replacements..notify-btn-iconmixin with.ui-btn-ctrl. Both mixins target the same generic notify selector,.notify__btn-icon..btn-iconand.btn-textcolor styles (background-colorandcolor).Note: @kirsty-hames and myself have decided to make this a draft PR in the first instance so we can gather feedback on the change to buttons before we progress with phase 2 of the buttons update. We're really keen for comments and thoughts on how we've grouped the buttons together.