Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video Speed menu is not accessible #297

Open
swashbuck opened this issue Jul 17, 2024 · 2 comments
Open

Video Speed menu is not accessible #297

swashbuck opened this issue Jul 17, 2024 · 2 comments
Assignees

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jul 17, 2024

Subject of the issue

The _speed player option is not accessible:

  1. The speed selector button does not have a meaningful label for screenreaders. The button is announced by default as the "one point zero zero x button"
  2. The speed selector button is not keyboard accessible. Mouse users can hover over the playback speed button to reveal more options, but when a keyboard users sets focus on the playback speed button and activates it with space or enter, nothing happens. Keyboard users are unable to change their playback speed.

In mediaLibrariesOverrides.js, we override (or add?) aria labels for use with MediaElement.js. So, perhaps we could add a label for speed here.

The focus issue is similar to that of captions. See #232

It may be possible to fix this by updating mediaelement / mediaelement-plugins? See https://github.com/mediaelement/mediaelement-plugins/blob/42dc804df0e98ea8de4d07a736690b72585d9c37/src/speed/speed.js#L110

Steps to reproduce

Add 'speed' to a Media component's player options. For example:

"_playerOptions": {
  "alwaysShowControls": false,
  "hideVideoControlsOnLoad": true,
  "showPosterWhenEnded": true,
  "features": [
    "playpause",
    "progress",
    "fullscreen",
    "volume",
    "speed"
  ]
},

Then, navigate to the option with a screenreader / keyboard navigation.

@swashbuck
Copy link
Contributor Author

Created #298 to look into updating the MediaElement library.

@swashbuck
Copy link
Contributor Author

Needs reviewing as part of #299

@swashbuck swashbuck self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Reviewing
Development

No branches or pull requests

1 participant