Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No focus outline on the dropdown button #194

Closed
oliverfoster opened this issue Sep 2, 2024 · 1 comment · Fixed by #195
Closed

No focus outline on the dropdown button #194

oliverfoster opened this issue Sep 2, 2024 · 1 comment · Fixed by #195
Assignees

Comments

@oliverfoster
Copy link
Member

Subject of the issue

Focus outline, when using keyboard, is explicitly disabled for each dropdown, before opening, at this line:

@kirsty-hames kirsty-hames self-assigned this Sep 4, 2024
@kirsty-hames
Copy link
Contributor

I can't see why we would need to explicitly remove the focus outline here. This is part of the initial implementation where we replaced select2 with native Adapt. Historically there's been a lot of back and forth on how we display focus, e.g user agent vs theme style or variable. So this may have been whilst we were defining the outline style via the theme.

I'll check this across browsers/devices then raise a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants