Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should drop downs read the label when opened? #190

Closed
joe-allen-89 opened this issue Jul 12, 2024 · 3 comments · Fixed by #191
Closed

Should drop downs read the label when opened? #190

joe-allen-89 opened this issue Jul 12, 2024 · 3 comments · Fixed by #191
Assignees
@joe-allen-89
Labels
accessibility bug question released

Comments

@joe-allen-89
Copy link
Contributor

Subject of the issue/enhancement/features

When tabbing through a page you're jumped to the select button, on opening the drop down list the screen reader reads out the option but not the label/question itself. From a usability point of view I think we should announce the label when opening the drop down to avoid any confusion.

Wondering if anybody has any reason not to do this/any reasons we've not done it before?
@joe-allen-89 joe-allen-89 self-assigned this Jul 12, 2024
@oliverfoster
Copy link
Member

Sounds good if you can make it happen. LabelledBy similar to mcq etc?

@joe-allen-89
Copy link
Contributor Author

Sounds good if you can make it happen. LabelledBy similar to mcq etc?

Exactly, add an ID to the label and use labelledby in the drop down.

joe-allen-89 added a commit that referenced this issue Jul 12, 2024
@joe-allen-89
Fix: aria-labelledby added to matching dropdown (fixes #190)
dd16360
@joe-allen-89 joe-allen-89 mentioned this issue Jul 12, 2024
Merged
@joe-allen-89 joe-allen-89 linked a pull request Jul 12, 2024 that will close this issue
Fix: aria-labelledby added to matching dropdown to read out dropdown label/question (fixes #190) #191
Merged
github-actions bot pushed a commit that referenced this issue Jul 24, 2024
@semantic-release-bot
Chore(release): 7.4.4 [skip ci]
fa85ae9 
## [7.4.4](v7.4.3...v7.4.4) (2024-07-24)

### Fix

* aria-labelledby added to matching dropdown (fixes #190) (#191) ([aa70a3f](aa70a3f)), closes [#190](#190) [#191](#191)
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 7.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug question released
Projects
None yet
Milestone
No milestone
2 participants
@oliverfoster @joe-allen-89