Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add class when using numbered pins #320

Closed
swashbuck opened this issue Sep 25, 2024 · 1 comment · Fixed by #321
Closed

Add class when using numbered pins #320

swashbuck opened this issue Sep 25, 2024 · 1 comment · Fixed by #321
Assignees

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Sep 25, 2024

Subject of the enhancement

It would be useful to add a class (e.g. has-numbered-pins) to the Hot Graphic when numbered pins are used. This will help with theming. I tried using the :has selector like :has(.hotgraphic__pin-number) but the pin number element is removed after the item is visited.

"_useNumberedPins": true

Are there any other utility classes we should add to assist with theming? Do we need a class to indicate _useGraphicsAsPins is being used?

@kirsty-hames
Copy link
Contributor

Are there any other utility classes we should add to assist with theming? Do we need a class to indicate _useGraphicsAsPins is being used?

_useGraphicsAsPins is already covered by 'is-tile' or 'is-pin' classes. I think all config options have a relevant class now that you've updated _useNumberedPins.

github-actions bot pushed a commit that referenced this issue Sep 30, 2024
# [6.14.0](v6.13.5...v6.14.0) (2024-09-30)

### Update

* Add has-numbered-pins class when using numbered pins (fix #320) (#321) ([f572710](f572710)), closes [#320](#320) [#321](#321)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants