Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Required fields for tile layout #314

Closed
swashbuck opened this issue Jul 22, 2024 · 0 comments · Fixed by #323
Closed

Framework: Required fields for tile layout #314

swashbuck opened this issue Jul 22, 2024 · 0 comments · Fixed by #323
Assignees
@swashbuck
Labels
enhancement

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jul 22, 2024 •
edited
Loading

Subject of the issue

The required fields for the tile layout need looking into.

  1. The _graphic property on the main component configuration is not required for the tile layout. However, if missing, it will throw an error about a missing _graphic property due to this line.
  2. The _top, _left and _imageAlignment properties are not needed for the tile layout. These should be removed from the example.json and a note should also be made in the README.md.

Steps to reproduce

Add the "_useGraphicsAsPins": true option and add graphics to each item to use the tile layout.

Environment

  • FW 5.40.3
  • Hot Graphic 6.13.4
@swashbuck swashbuck changed the title Required fields for tile layout FW: Required fields for tile layout Jul 22, 2024
@swashbuck swashbuck changed the title FW: Required fields for tile layout Framework: Required fields for tile layout Jul 22, 2024
@swashbuck swashbuck self-assigned this Oct 3, 2024
@swashbuck swashbuck mentioned this issue Oct 3, 2024
Merged
oliverfoster pushed a commit that referenced this issue Oct 15, 2024
@swashbuck
Fix: Remove unnecessary properties for tile/grid layout (fixes #314) (#…
14d062c 
…323)
github-actions bot pushed a commit that referenced this issue Oct 15, 2024
@semantic-release-bot
Chore(release): 6.14.2 [skip ci]
4b780a0 
## [6.14.2](v6.14.1...v6.14.2) (2024-10-15)

### Fix

* Remove unnecessary properties for tile/grid layout (fixes #314) (#323) ([14d062c](14d062c)), closes [#314](#314) [#323](#323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swashbuck swashbuck

Labels
enhancement
Projects
None yet
Milestone
No milestone
1 participant
@swashbuck