Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Title is required to set notify popup dialog label #294

Closed
kirsty-hames opened this issue Jan 31, 2024 · 1 comment · Fixed by #295
Closed

Title is required to set notify popup dialog label #294

kirsty-hames opened this issue Jan 31, 2024 · 1 comment · Fixed by #295
Assignees
@kirsty-hames
Labels
accessibility released

Comments

@kirsty-hames
Copy link
Contributor

Subject of the issue

As per Core issue Notify role="dialog" requires a label. The popup uses the title to set the dialog label.

Expected behaviour

Title should be set to required as without this, the popup dialog won't be properly identified by assistive technologies.
@kirsty-hames kirsty-hames self-assigned this Jan 31, 2024
@kirsty-hames kirsty-hames mentioned this issue Jan 31, 2024
Merged
joe-allen-89 pushed a commit that referenced this issue Mar 4, 2024
@kirsty-hames
Fix: Title is required to set notify popup dialog label (fixes #294) (#…
eacdcd8 
…295)

* Set properties.schema item title to required

* set item title as required in component.schema
github-actions bot pushed a commit that referenced this issue Mar 4, 2024
@semantic-release-bot
Chore(release): 6.11.1 [skip ci]
a818795 
## [6.11.1](v6.11.0...v6.11.1) (2024-03-04)

### Fix

* Title is required to set notify popup dialog label (fixes #294) (#295) ([eacdcd8](eacdcd8)), closes [#294](#294) [#295](#295)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#296) ([e8305ca](e8305ca)), closes [#296](#296)
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 4, 2024

🎉 This issue has been resolved in version 6.11.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
1 participant
@kirsty-hames