You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using the _isNarrativeOnMobile option, the Hot Graphic component will change to a Narrative component on mobile. The problem is that the new Narrative component is always added to the end of the block's contents in the DOM order. This breaks the intended order of any components in the same block.
I believe this is because the Narrative/Hot Graphic is always appended to the block without regard for the original order:
Subject of the issue
When using the
_isNarrativeOnMobile
option, the Hot Graphic component will change to a Narrative component on mobile. The problem is that the new Narrative component is always added to the end of the block's contents in the DOM order. This breaks the intended order of any components in the same block.I believe this is because the Narrative/Hot Graphic is always appended to the block without regard for the original order:
adapt-contrib-hotgraphic/js/hotgraphicView.js
Line 44 in a4b949e
The Narrative's
replaceWithHotgraphic()
also has the same behavior where the component is appended to the end of the block.Your environment
Steps to reproduce
_layout
_layout
_isNarrativeOnMobile: true
on the Hot GraphicExpected behaviour
The Graphic component should be below the Hot Graphic on mobile and to the right on desktop.
Actual behaviour
It is not so.
Screenshots
Before switching to Mobile
After switching to Desktop from Mobile
The text was updated successfully, but these errors were encountered: