Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "reset" button on Field Search UI closes Search #646

Open
dennisbulgatz opened this issue Aug 13, 2020 · 1 comment
Open

The "reset" button on Field Search UI closes Search #646

dennisbulgatz opened this issue Aug 13, 2020 · 1 comment

Comments

@dennisbulgatz
Copy link

dennisbulgatz commented Aug 13, 2020

The "reset" button in the field search Form UI closes the search window. Should simply reset all values in the search to default, and leave the search form open for new search parameters.

@scambra
Copy link
Member

scambra commented Aug 13, 2020

Reset button in search forms (normal search form and field search) have always reset listing and close form. Reset button is not a input type=reset element, although it could call form.reset(). However, when list.refresh_with_header is enabled, all list element is replaced, so search form is gone anyway, so it is not so easy to avoid closing form when refresh_with_header is enabled.

I don't want to convert reset button in a simple reset function, because it would change behaviour of existing apps, although I can consider removing close form behaviour and call form.reset(), but it will have to reopen search form if refresh_with_header is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants