Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patched versions of ORCA should fail tests #171

Closed
danepowell opened this issue Oct 19, 2021 · 1 comment
Closed

Patched versions of ORCA should fail tests #171

danepowell opened this issue Oct 19, 2021 · 1 comment

Comments

@danepowell
Copy link
Contributor

danepowell commented Oct 19, 2021

ORCA-integrated projects are responsible for installing an up-to-date and unaltered version of ORCA. If projects use an out-of-date or patched version of ORCA, it opens the possibility of tests passing on that project but failing for other ORCA projects (i.e. causing an outage).

As an after-success script, I propose that ORCA scan itself to determine if it is up-to-date and unpatched, and fail tests otherwise. This would hopefully prevent (or at least make it more difficult) for consuming projects to merge a PR that causes an ORCA outage.

I propose an after-success script so that if a project is testing an ORCA patch, they can see that it's successful (for whatever purpose) before tests fail.

@TravisCarden TravisCarden changed the title Patched or non-current versions of ORCA should fail tests Patched versions of ORCA should fail tests Oct 21, 2021
@Raksha-Bharuka
Copy link
Contributor

Closing this issue because it has been inactive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants