Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--check does not check syntax errors #41

Open
BhaagBoseDK opened this issue Aug 7, 2021 · 3 comments
Open

--check does not check syntax errors #41

BhaagBoseDK opened this issue Aug 7, 2021 · 3 comments

Comments

@BhaagBoseDK
Copy link
Contributor

--check does not check syntax error.

for
[new section]
node.id = something

I had a - instead of _ mistake in
max.chan-ratio (instead of max.chan_ratio

Also I had spelling mistake

strategy = proportional

These were not caught during --check and instead they were caught in --dry-run

@accumulator
Copy link
Owner

You are correct, many parts of the config file are evaluated late, after --check does its thing. --check basically only does a 'does this look like an INI style file?'

@BhaagBoseDK
Copy link
Contributor Author

may be worth checking syntax as well as part of --check.

@accumulator
Copy link
Owner

You are correct again, that's why I kept this bug report open :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants