Replace all store.push(type, data) calls with store.push(data) calls

[igorT]

Ember data has all the necessary helpers that do this, just need to use those and notice where store.push is used. Will need to parse DS.Model definitions for it to work though

[Serabe]

Can you please provide more info on dropping the type argument?

[knownasilya]

@Serabe since push now takes a JSON API object, which has all the relevant data, so the type has become redundant. See the blog post: http://emberjs.com/blog/2015/06/18/ember-data-1-13-released.html#toc_internal-format-change-to-json-api

[Serabe]

Thank you, @knownasilya. Then, one conversion would be:

store.push('post', {
  id: 'my-post',
  title: 'Post title',
  author: 'knownasilya',
  comments: [
    { id: 'first', type: 'comment'},
    { id: 'second', type: 'pingback'},
  ],
});

to:

store.push({
  id: 'my-post',
  type: 'post',
  data: {
    attributes: {
      title: 'Post title',
    },
    relationships: {
      author: {
        data: {id: 'knownasilya', type: 'user'},
      },
      comments: {
        data: [
          {id: 'first', type: 'comment'},
          {id: 'second', type: 'pingback'},
        ]
      }
    }
  }
});

Wouldn't it?

Note: The json was written by hand directly in the comment textarea, there might be some unbalance [, { or (.

P.S. Just so nobody gets nervous reading this, ), }, ]. xkcd

[abuiles]

We might also need support for store.find, store.all, store.getById

[Serabe]

@abuiles I don't see how those methods change after JSONAPI.

[igorT]

agreed