Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Don't use Vite library mode #41

Open
1 task done
abiriadev opened this issue Jun 9, 2024 · 2 comments
Open
1 task done

[Feat]: Don't use Vite library mode #41

abiriadev opened this issue Jun 9, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@abiriadev
Copy link
Owner

abiriadev commented Jun 9, 2024

Problem

Seia currently using Vite's lib mode to build the app.

lib: {
formats: ['es'],
},

This is a wrong approach since we are building an end application.

Suggestion

We can read index.html file as an entry point, or we can provide 'virtual' index.html file at build time.

Willingness to Contribute

  • I'm willing to actively contribute to it

Related Issues

@abiriadev abiriadev added the enhancement New feature or request label Jun 9, 2024
@abiriadev abiriadev self-assigned this Jun 9, 2024
@nemorize
Copy link
Contributor

we can provide 'virual' index.html file at build time.

You mean 'virtual'?

@abiriadev
Copy link
Owner Author

@nemorize Fixed it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

2 participants