Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature] Offline Songs With Indexed DB #3

Open
INF800 opened this issue Jul 4, 2020 · 9 comments
Open

[New Feature] Offline Songs With Indexed DB #3

INF800 opened this issue Jul 4, 2020 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@INF800
Copy link

INF800 commented Jul 4, 2020

I can contribute for this feature. Kindly let me know if we can work on it.

@abhisheknaiidu
Copy link
Owner

@rakesh4real Yea sure, but how exactly are we adding this feature?

@INF800
Copy link
Author

INF800 commented Jul 4, 2020

I can write a module to write and read data from indexed DB. As I don't know much about design of your web app I may need your help integrating it

@abhisheknaiidu
Copy link
Owner

@rakesh4real Oh ok, sounds good to me, Yea I'll help, whenever there is a need of me 😄

@abhisheknaiidu
Copy link
Owner

@rakesh4real are you working? Let me know if I can do any help!

@TumoM
Copy link

TumoM commented Aug 3, 2020

@abhisheknaiidu I'd like to give this feature a shot. I'll make a pull request if I manage! 😇

@INF800
Copy link
Author

INF800 commented Aug 3, 2020

@abhisheknaiidu I apologize for not being able to work on the feature. There was a sudden change of plan at my work which needed my undiverted attention. 

@TumoM Hi, if you are new to IndexedDB checkout
this gist. It will give you a jump start. Instead of saving strings, save string representation of binary data or do something similar to it

@TumoM
Copy link

TumoM commented Aug 3, 2020

@abhisheknaiidu I apologize for not being able to work on the feature. There was a sudden change of plan at my work which needed my undiverted attention. 

@TumoM Hi, if you are new to IndexedDB checkout
this gist. It will give you a jump start. Instead of saving strings, save string representation of binary data or do something similar to it

@rakesh4real you're completely right, and we're on the same page with the binary idea, plain strings probably won't work. I did a little demo trying to pull only the audio from a YouTube video online, saving that to a Base64 string, and passing it into the Player Component (React Player) and it surprisingly worked. So now it's just time to sort out the logic within the app.

Good advice, thank you!

@abhisheknaiidu
Copy link
Owner

@rakesh4real It's fine!
and @TumoM thanks for showing interest, lemme me know if you want any help!

@TumoM
Copy link

TumoM commented Aug 5, 2020

@rakesh4real It's fine!
and @TumoM thanks for showing interest, lemme me know if you want any help!

Thanks @rakesh4real. I've just been experimenting with saving a song offline first without corrupting it, and passing that data to React Player.

@abhisheknaiidu gave a good gist for working with IndexDb. I'll get more done over the weekend.

I'll try implement the feature for the currently playing song, and get a working version going. I'll probably store an offline boolean in the store/state/context for each song , that runs a check against the IndexDb at startup and when a user presses play on a song. Otherwise it will fetch from the link. Tell me what you think about that flow @rakesh4real

@abhisheknaiidu abhisheknaiidu added enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants