Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discontinued #172

Open
abdelaziz-mahdy opened this issue Aug 26, 2023 · 13 comments
Open

Discontinued #172

abdelaziz-mahdy opened this issue Aug 26, 2023 · 13 comments

Comments

@abdelaziz-mahdy
Copy link
Owner

abdelaziz-mahdy commented Aug 26, 2023

hello i set my package as Discontinued https://pub.dev/packages/flutter_meedu_videoplayer since most of the features are already done in media_kit and i would rather focus my effort to help in media_kit instead of each of us implementing the same features (and i cant implement most of the native ones since they are in media_kit and video_player which limits my ability to fix/improve it)

and working full time makes it hard to fix bugs / implement new features.

sorry for everyone using the package

for people that want to use the controls or media_kit with fvp or video_player i recommend https://pub.dev/packages/universal_video_controls

@abdelaziz-mahdy abdelaziz-mahdy pinned this issue Aug 26, 2023
@AnonymHK
Copy link

Very regretful! I don't know how to describe my mood!

@abdelaziz-mahdy
Copy link
Owner Author

I am sorry it had to be done for the better good, instead of each of us just trying to accomplish the same features

Having one package with everything is much easier for people and for us.

@AnonymHK
Copy link

In the short term, I will not give up on 'flutter_meedu_videoplayer', media_ Although the kit is very professional, it is very unfriendly to new users. After reading it for half an hour, I still don't know how to customize the UI, and there are few documents available. It's still good to use the 'flutter_meedu_videoplayer'! No matter what others think of media_ Kit, I think the components with high learning costs are just bullshit!

@AnonymHK
Copy link

The development of components is for people to use, relying on ease of use and stability, rather than unprofessional code! He criticized your code for being poor, but his likes on pub.dev are only a few dozen more than yours, and it turns out that you're not doing worse than theirs! It's a pity to give up!

@abdelaziz-mahdy
Copy link
Owner Author

i didnt give up, i cant maintain the package anymore, rather than trying to keep up the features i dont have time to do it or the energy to do it

i kept the package up for a while costing me time and energy when i didnt have any, so it was consuming too much for me

i did discontinued the package but it should work for a good while, and its a statement from me that i cant maintain it anymore, to not make people believe that i will update it when i will not and leave people hanging like other packages do

@hitesh-yoboshu
Copy link

hitesh-yoboshu commented Aug 28, 2023

@AnonymHK

The only thing that I've seen you do on internet is spread hate. I kindly ask you to stop gaslighting people.

No one is giving-up, losing or winning.

As author of package:dart_vlc & package:media_kit, I've been serving the users of package:flutter_meedu_videoplayer since the beginning. I'm sure package:media_kit will directly meet your needs & fulfil your project requirements, I welcome you. For the small parts where there's still something missing (although I believe everything has been covered), you are welcomed to contribute or provide feedback.

I have noticed most users already migrated to package:media_kit without any help, fairly easy.


His likes on pub.dev are only a few dozen more than yours.

First of all, nothing is his or her. All these are community projects under completely open-source license.

package:dart_vlc powered package:flutter_meedu_videoplayer long before package:media_kit.

Publish dates of all the packages:

  • March 15, 2021
    • package:dart_vlc
  • June 22, 2022
    • package:flutter_meedu_videoplayer
  • February 27, 2023
    • package:media_kit

It's obvious that the package which was published before will have higher amount of likes.

It's a surprise package:media_kit managed to surpass it in short-time, in that sense GitHub stars can be another parameter. It takes time for industry & community to adopt. The search-engines etc. are also more friendly to older pages & links.

Secondly, the complexity level of the two projects i.e. package:flutter_meedu_videoplayer & package:media_kit is entirely different. The first one i.e. package:flutter_meedu_videoplayer is set of video controls, handful more fixes & other utilities, while the later i.e. package:media_kit is native-interop, every platform's native implementation, video embedding, cross-compilation, ANGLE, OpenGL, Direct3D, METAL etc.

The existence of package:flutter_meedu_videoplayer was completely justified at that time, since package:media_kit was only able to play video on Windows (with black flickers) during initial stages. Everything came a long way & now all platforms are supported, including most of the features which package:flutter_meedu_videoplayer had.

Everyone is free to examine the quality, behavior & implementation of package:media_kit e.g. performance, video-controls etc. In-fact everyone is fairly satisfied with the experience.

No matter what others think of media_ kit, I think the components with high learning costs are just bullshit.

The first code sample for package:media_kit is just 50 lines!!!

In this, even the video-controls are added by default (other than actual advantages), which already have higher-level of customization than the ones in package:flutter_meedu_videoplayer. A different variant for cupertino, material & material-desktop is also available.

After reading it for half an hour, I still don't know how to customise the UI.

The video-controls in package:media_kit work in exact same way as Flutter's ThemeData.

If you've worked with frontend, you must've heard "inline styling bad".

One more thing I'd like to add is that, video-controls are highly customisable in package:media_kit with way more options, this may make it seem complex on the first glance. This is the key, keep things simple for everyone at surface but give advanced features if one dives deep.

The development of components is for people to use, relying on ease of use and stability.

Trust me, it's easier & simpler than the ones here.

You know what's better? You can submit your feedback or improvements (it's open source)!

The stability & performance is always important & good to have.

There are few documents available.

Like I said, package:media_kit is very-very complex at it's core & I had to implement everything for all platforms. Actual design & implementation challenges were involved. It wasn't feasible for me to solely focus on public documentation. But, people can improve it. Regardless, all people have been able to learn things fairly easy without any help at all.


@zezo357 is also one of the developers of package:media_kit. I believe this is good for everyone i.e. focusing on a single project & delivering quality code, instead of splitting our efforts & going nowhere. I mostly work with native & C/C++ part of the project, everyone has their own strengths & I believe the better will be to give your best part.

@alexmercerind

@usman615
Copy link

@hitesh-yoboshu @zezo357

is there any support for selecting audio tracks from various media URL formats like .mp4, .mkv, and .m3u8 in media kit? and video qualities for .m3u8 URLs.

@abdelaziz-mahdy
Copy link
Owner Author

abdelaziz-mahdy commented Aug 28, 2023

@hitesh-yoboshu @zezo357

is there any support for selecting audio tracks from various media URL formats like .mp4, .mkv, and .m3u8 in media kit? and video qualities for .m3u8 URLs.

audio tracks yes

for video qualities for .m3u8 URLs, i dont think its supported by default but you can make it work by using the example in this package and just migrate it to media_kit

@usman615
Copy link

@zezo357 @hitesh-yoboshu

Please help me with that like in media_kit video player add a setting icon when tap on it show dropdown menu with two options one for selecting video quality and second for audio tracks, when tap on any available video quality/audio track Initialized mediakit player accordingly.

@abdelaziz-mahdy
Copy link
Owner Author

Sadly I can't help with that now, can you check the available examples and the documents and ask what is the problem that you are having?

@usman615
Copy link

Ok brother I will let you know when I complete the video player till the drop-down menu

@usman615
Copy link

@zezo357
brother i open a issue on media_kit package. please help me there

https://github.com/media-kit/media-kit/issues/424

@bryanjorgeflores
Copy link

This makes me sad man, but I understand. I really really want to thank you for all your effort and dedication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants