Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifetimeReserveFactorAccrued is incorrect for V3 markets #75

Open
defispartan opened this issue Jun 28, 2022 · 1 comment
Open

lifetimeReserveFactorAccrued is incorrect for V3 markets #75

defispartan opened this issue Jun 28, 2022 · 1 comment

Comments

@defispartan
Copy link
Contributor

defispartan commented Jun 28, 2022

The accruedToTreasury value looks correct, but lifetimeReserveFactorAccrued > lifetimeSupplierInterestAccrued which does not make sense as reserve factor is a percentage of supplier interest.

Query:

{
  reserves(first: 50, orderBy: lastUpdateTimestamp, orderDirection: desc) {
      id 
      underlyingAsset
      lifetimeReserveFactorAccrued
      lifetimeSuppliersInterestEarned 
      accruedToTreasury
   }
}
@sakulstra
Copy link
Contributor

I'm not sure if that's wrong.
lifetimeReserveFactorAccrued is "borrow fees + liquidation fees + flashloan protocol fees + (portal fees)" where lifetimeSuppliersInterestEarned is only "accumulated interest on aTokens" ( not 100% srure, but i think excluding all the other fees that lps get)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants