Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect Graphviz nodes directly instead of using strings #25

Open
Clifford-appliedAI-GmbH opened this issue Apr 19, 2023 · 0 comments
Open
Labels
minor For small issues

Comments

@Clifford-appliedAI-GmbH
Copy link
Collaborator

Currently there a lot of

s1, s2 = "abc", "xzy"
node1, node2 = pydot.Node(s1, ...), pydot.Node(s2, ...)
edge = pydot.Edge(s1, s2)

This is fine for smaller bits of code, but it can be a bit unclear when the code is more complex since we're connecting the nodes by "coincidentally" giving relevant things the same string names. It might be a bit better to move towards

edge = pydot.Edge(node1.get_name(), node2.get_name())
@Clifford-appliedAI-GmbH Clifford-appliedAI-GmbH added enhancement New feature or request minor For small issues labels Apr 19, 2023
@Clifford-appliedAI-GmbH Clifford-appliedAI-GmbH removed the enhancement New feature or request label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For small issues
Projects
None yet
Development

No branches or pull requests

1 participant