New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are edits tied to a neighbourhood boundary or not? #77

Open

dabreegster opened this issue Jan 12, 2025 · 1 comment

Labels

good first issue

Collaborator

dabreegster commented Jan 12, 2025

Something quite weird today:

Draw a neighbourhood boundary
Change some filters, one-ways, etc inside there
Delete the boundary

The edits remain, but the user can't just go and click on an edited filter to delete it. Not sure how this should work.

Relatedly, from the main "pick neighbourhood" page, should there be a "clear all edits" option, or a summary of the edits?

dabreegster added the good first issue label

dabreegster mentioned this issue

Start impact prediction mode #83

Merged

Collaborator Author

dabreegster commented Jan 22, 2025

Notes from chat with @michaelkirk:

the undo/redo feels broken now, because it crosses different neighbourhoods
we could offer / force deleting all edits when deleting a boundary or changing it... except what if there's an overlapping other boundary that covers some/all?
this probably isn't the most important thing to fix; a user can go edit something uneditable by drawing a new boundary around it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment