Improve Input fields to supporting functions as in other places of Freecad.

[leoheck]

What do you think if we convert these X, Y, Z translation fields:

to these fields that support function?
This is a sample from Sheetmetal Workbench (I can take a look at what is done there so we could easily have this on Asm4 too)

[Zolko-123]

yes that would be awesome ! If you can have a look that would be nice indeed

[leoheck]

Cool, I will take a look on it.

[leoheck]

I also found out that the current field is a bit limited too.
I cannot paste a value with more than 2 decimal places.
I can paste 12.34 but not 12.345

[leoheck]

What do you think?

[Zolko-123]

yes this looks good for the translation, but I don't think it is adapted to the rotation.

Can you make a PR with your proposal to only replace the translation input, leaving the rotation part as-is ? We will see for the rotation afterwards

[Zolko-123]

lets keep the 2 updates separated please. Doing everything in 1 PR is a lot of trouble to debug

[leoheck]

I see but I am not updating anything. That is just an image. What I would like to understand is why you said the rotation cannot have the same kind of field. It looks reasonable for me to have this. The current rotation is really limiting and there is no reason for that limitation.

[Zolko-123]

the point is : translations around the 3 axes are independent, but the rotations around 3 axes are not.

If (for example) you need two 90° rotations around X and a rotation around Y to get the correct orientation of your part, and then you want to add an extra parametric continuous rotation around Z, how will all these rotations be combined into a single rotation matrix ? Because at the end there is a single AttachmentOffset placement for all these movements.

Therefore for continuous rotations I always suggest to add an extra intermediate LCS

[leoheck]

Ah, ok, so you are suggesting the rotation is complicated. Alright, I get that. I am going to experiment this a bit to see if I can make it happen and then I am going to make some small PR's, cool?

[Zolko-123]

yes that would be cool, thank-you

[leoheck]

I could make rotation work, but when opening the Place linked part again values of the angles change. That is not nice but I could not improve this.

Then an intermediate step would be something like this.. where the user can change the rotation step.. So the angle is not visible. Also, another button is there to reset the original/initial rotation of the axis.

It would be nice to have this step stored on a property for each link. So, if the user needs something specific.. it will be easy to adjust on a second try. Right now I did not do that. It is always 90o when this window opens.

[Zolko-123]

when opening the Place linked part again values of the angles change

I was expecting something like this.

Let's keep it simple: the translation input fields are a great improvement, can you make a PR with that ? The rotation thing makes it much more convoluted, for a gain that is not obvious.

[leoheck]

Hey @Zolko-123 , I did not forget about this. It happens is that I did not have time to make this PR with fewer options.

I saved my work here in case you would like to check this working.
https://github.com/leoheck/FreeCAD_Assembly4/tree/fx_fields