Skip to content
This repository has been archived by the owner on Jul 17, 2020. It is now read-only.

Cache last N messages per room to enable sed functionality globally. #232

Closed
Shmiddty opened this issue Mar 30, 2015 · 7 comments
Closed

Comments

@Shmiddty
Copy link
Contributor

The title speaks for itself.

@CS1000
Copy link

CS1000 commented Mar 31, 2015

Can't it just read last 100 messages in the room it was invoked and return the first one that can be replaced?

Cache smells leaky...

@SomeKittens
Copy link
Contributor

@CS1000 currently, it reads the DOM for the !!s command. It can only read the DOM for the room that's currently up in the tab.

@CS1000
Copy link

CS1000 commented Mar 31, 2015

what about reply-ing to a message like:

:2709976 s/search/replacement/gi

instead of !!s

@Shmiddty
Copy link
Contributor Author

Shmiddty commented Apr 4, 2015

@CS1000 That's not a bad idea, but I don't think it solves the cross-room problem.

@CS1000
Copy link

CS1000 commented Apr 4, 2015

@Shmiddty it would requre fetching the exact message id, abuse shouldn't be a problem with a timed execution. http://chat.stackoverflow.com/messages/22491127/history

@Zirak
Copy link
Owner

Zirak commented Jan 22, 2016

Replacing a specific message was handled in #220 though we still use the DOM. Honestly, anything to do with messages that isn't in the current DOM is blocked on the same thing #27 (and many more things) are blocked on: Specifically how the bot has no internal representation of the room it's in or the chat in general.

@Zirak
Copy link
Owner

Zirak commented Jan 22, 2016

owait, this is a duplicate of #216.

@Zirak Zirak closed this as completed Jan 22, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants