Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixed Type Graph #297

Open
ZigRazor opened this issue May 15, 2023 · 4 comments
Open

Mixed Type Graph #297

ZigRazor opened this issue May 15, 2023 · 4 comments
Assignees
Labels
core something about core development Development of new Functionalities enhancement New feature or request hacktoberfest hacktoberfest issue Priority:Low Priority Label for low priority issue

Comments

@ZigRazor
Copy link
Owner

          I Think it's also useful work on mixed type graph (a graph that can contains different type of node or edges).

But it can be another issue.

Originally posted by @ZigRazor in #284 (comment)

@ZigRazor ZigRazor added enhancement New feature or request development Development of new Functionalities core something about core Priority:Low Priority Label for low priority issue labels May 15, 2023
@ZigRazor ZigRazor added the hacktoberfest hacktoberfest issue label Sep 26, 2023
@sbaldu
Copy link
Collaborator

sbaldu commented Oct 9, 2023

I was thinking about this. Maybe this could be done by adding a layer of inheritance to the Nodes, similar to the structure of the Edges.
We could simplify Node so that it only contains the node indexes (and is not templated any more), and then define another class (DataNode maybe?)
which is defined as:

template <typename T>
class DataNode : public Node {};

So in this way all the different types of nodes would be derived from the same base class, and we should be able to use different node types in the same graph.

Let me know what you think.

@ZigRazor
Copy link
Owner Author

ZigRazor commented Oct 9, 2023

Good Idea! I think we can proced.
This is possible also because we already have an API break, so next release can contains this interface changes!
What do you think @nrkramer?

@sbaldu
Copy link
Collaborator

sbaldu commented Oct 9, 2023

Good Idea! I think we can proced.

If you want I can work on this.

@ZigRazor
Copy link
Owner Author

ZigRazor commented Oct 9, 2023

Good Idea! I think we can proced.

If you want I can work on this.

Yes, you can work on it!

@sbaldu sbaldu self-assigned this Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core something about core development Development of new Functionalities enhancement New feature or request hacktoberfest hacktoberfest issue Priority:Low Priority Label for low priority issue
Projects
None yet
Development

No branches or pull requests

2 participants