Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion] Changing KEY_{NUMBER} keys to KEY_KP{NUMBER} keys #137

Open
CRImier opened this issue Nov 22, 2018 · 0 comments
Open

[Discussion] Changing KEY_{NUMBER} keys to KEY_KP{NUMBER} keys #137

CRImier opened this issue Nov 22, 2018 · 0 comments

Comments

@CRImier
Copy link
Member

CRImier commented Nov 22, 2018

I'm thinking about the QWERTY keyboard compatibility. The ZPUI input system, by and large, uses Linux input keycode names, so there's no fundamental incompatibility between current input devices and QWERTY keyboards. However, there's a small problem - we can't quite unite the ZPUI keypad-suitable (NumpadCharInput) and QWERTY-suitable (NumpadKeyboardInput) UI elements into one, because the number keys (KEY_{NUMBER}) conflict, they allow input of characters for the first UI element but input of numbers for the last one. In order to merge two UI elements into one (which I think is the preferred way of QWERTY-keypad coexistence), we need to somehow resolve that conflict. For now, I was thinking about changing the ZeroPhone keypad's keycodes from codes like KEY_0 to QWERTY keyboard numpad codes, like KEY_KP0. That would allow us to use the ZP keypad and QWERTY keyboards seamlessly in a single UI element. However, it's a change that touches a lot of ZPUI internals, and its impact needs to be considered better.

  • We'll need to change the UI elements
  • We'll need to improve mechanisms used by UI elements for checking whether there's enough keypad keys for them to function
  • We'll need to change some tutorials and manuals (like ZP Wiki keycode page)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant