feature: restore JSON-RPC 1.0 support

[conradoplg]

Motivation

Zebra used to support both JSON-RPC 1.0 or 2.0 in respect to the jsonrpc field (non-existent in 1.0, mandatory with the 2.0 value in 2.0).

However, after the migration to jsonrpsee, this does not work anymore, and tools like zcash-cli stopped working with

{"jsonrpc":"2.0","id":"curltest","error":{"code":-32600,"message":"Invalid request"}}

We might want to restore that support. We already replace requests with jsonrpc = "1.0" (which is nonsensical, since the field did not exist in 1.0, but some tools like lightwalletd use it) to jsonrpc = "2.0" using a middleware; it might be simple to make it add jsonrpc = "2.0" if the jsonrpc field is missing.

Specifications

No response

Complex Code or Requirements

No response

Testing

No response

Related Work

No response

[str4d]

I have this working in zallet. I based my JSON-RPC handler on zebrad and zebra-rpc (but couldn't depend on either), and in addition to fixing this bug I enhanced it to correctly map responses back to whatever the client expects in responses. I'll try find time to port my patch to zebra.