Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or comment out zebra internal miner #8180

Closed
1 of 2 tasks
oxarbitrage opened this issue Jan 22, 2024 · 0 comments · Fixed by #8184
Closed
1 of 2 tasks

Remove or comment out zebra internal miner #8180

oxarbitrage opened this issue Jan 22, 2024 · 0 comments · Fixed by #8184
Assignees
Labels
A-release Area: Zebra releases and release management C-removal Category: Features that have been removed P-High 🔥

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Jan 22, 2024

In #8136 we added an internal miner to zebra that depends on changes made to the ECC equihash crates. The problem is that this changes are currently in the form of pull requests, unpublished in crates.io. For this reason the release publishing to crates.io of Zebra is failing as all dependencies must be published. More info in #8165 (comment)

We need to fix this in order to complete the current ongoing release (1.5.1) which was made in github but was not published to crates.io.

We decided to remove the internal miner code as a temporal solution until the needed PRs (zcash/librustzcash#1088 and zcash/librustzcash#1083) are merged and a new version is published.

This ticket is to:

  • remove the dependency and related code that depends on it.
  • open a ticket to restore once stuff gets merged and new version published.

Follow up work

Create a hotfix release (1.5.2) with the changes done.

@github-project-automation github-project-automation bot moved this to New in Zebra Jan 22, 2024
@oxarbitrage oxarbitrage added C-removal Category: Features that have been removed A-release Area: Zebra releases and release management P-High 🔥 labels Jan 22, 2024
@oxarbitrage oxarbitrage self-assigned this Jan 22, 2024
@mergify mergify bot closed this as completed in #8184 Jan 23, 2024
@github-project-automation github-project-automation bot moved this from New to Done in Zebra Jan 23, 2024
@oxarbitrage oxarbitrage mentioned this issue Jan 23, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-release Area: Zebra releases and release management C-removal Category: Features that have been removed P-High 🔥
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant