Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extra tests for getblocktemplate-rpcs feature #7362

Closed
Tracked by #7366
teor2345 opened this issue Aug 21, 2023 · 2 comments · Fixed by #7753
Closed
Tracked by #7366

Remove extra tests for getblocktemplate-rpcs feature #7362

teor2345 opened this issue Aug 21, 2023 · 2 comments · Fixed by #7753
Assignees
@teor2345
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 21, 2023 •
edited
Loading

Motivation

Currently we have duplicate tests with and without getblocktemplate-rpcs. We can delete some of these tests after ticket #7361 merges.

Complex Code or Requirements

We should delete Rust tests we aren't using any more.

Some tests might fail and need to be fixed as part of ticket #7361.

Testing

We can manually check there's still one instance of every test when we review the PR.

Related Work
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup S-needs-triage Status: A bug report needs triage P-Low ❄️ labels Aug 21, 2023
@mpguerra mpguerra added this to Zebra Aug 21, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Aug 21, 2023
@mpguerra mpguerra mentioned this issue Aug 22, 2023
Closed
17 tasks
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @oxarbitrage @teor2345 @upbqdn

@teor2345
Copy link
Contributor Author

This is currently blocked by an open refactor that changes workflow names and structures. Once that merges, we can delete some of the workflow jobs in the PR for this ticket.

(I can open a PR on top of the workflow structure PR at any time, but merging any changes can get complicated.)

This was referenced Oct 13, 2023
Closed
Merged
Merged
@mpguerra mpguerra linked a pull request Oct 17, 2023 that will close this issue
change(ci): Remove duplicate CI jobs for getblocktemplate-rpcs #7753
Merged
6 tasks
@mergify mergify bot closed this as completed in #7753 Oct 22, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Zebra Oct 22, 2023
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-cleanup Category: This is a cleanup
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(ci): Remove duplicate CI jobs for getblocktemplate-rpcs ZcashFoundation/zebra
2 participants
@mpguerra @teor2345