-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Returns culprit for Error::InvalidSecretShare
#725
Comments
Thanks for the report! I believe it's not possible to identify a culprit in that step. That's Round 2, Step 2 of the DKG as described in the paper. There, the participant is receiving the |
Thank you for your reply. Are you completely sure about your answer? Because as far as I can see // The only one place which is not verified.
// Participant `i` generated it using packages from round1, which can be verified on round2.
// So, if this is an incorrect package that can be only, because participant `i` made a mistake or offense.
f_ell_i = round2_packege_from_i_to_me.signing_share;
// Аlready validated by `round2` on my side - so sure about correctness.
commitment = round1_package_from_i.commitment;
// This is my secret key generated by `round2`, which has verification of packages from other participant,
// so I'm sure about it
secret_key = my_round2_secret_key;
// So, as described in comment `f_ell_i` - `f_ell_i` is only one which can be incorrect and is only because of participant `i` actions.
verify(f_ell_i, commitment, secret_key) About article which you provide:
So, as I can see in the article, the three-round DKG does not have this issue. |
Oh you're right, I got confused, thanks. We'll work on this! |
The
culprit()
is None forInvalidSecretShare
:frost/frost-core/src/error.rs
Lines 128 to 136 in dcf1773
This is not expected behaviour because this error can be returned in DKG round 3
frost/frost-core/src/keys/dkg.rs
Lines 525 to 528 in dcf1773
So, because this error can be caused by other participant, I think culprit must be added to
InvalidSecretShare
.The text was updated successfully, but these errors were encountered: