Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounds cannot be longer than the size of the page #52

Open
AG-ZL opened this issue Dec 12, 2024 · 2 comments
Open

Sounds cannot be longer than the size of the page #52

AG-ZL opened this issue Dec 12, 2024 · 2 comments

Comments

@AG-ZL
Copy link

AG-ZL commented Dec 12, 2024

for some reason, all sounds are limited to 16 'blocks' long, though in the original it was never limited

loading a song with a super long sound doesn't appear to break anything
image
longer notes are helpful for some low sounds occasionally, and i feel like this is the kind of thing that is fixed by changing a single value

@AG-ZL
Copy link
Author

AG-ZL commented Dec 12, 2024

nevermind there's 1 issue;
in the arrangement timeline, the note doesn't end where its supposed to. in the first picture, on blue, the note appears to end 10 sections before its supposed to. (otherwise 34 sections long)

image of how it looks in original bosca:
image

this is however a minor visual glitch, and the note plays for the duration it's supposed to.
also in both versions, the line ceases to exist when the source block goes offscreen, which is a non-issue

@YuriSizov
Copy link
Owner

Hey there! Thanks for the report. So this has been brought up before in #28. There is indeed a limit to the note length in Bosca 3.0 and you can't set lengths beyond the size of the pattern.

I wasn't aware that people used extremely lengthy notes, and it the unlimited length didn't appear as a feature to me. That's because making the note of a large size requires a lot of tedious input from the user, like scrolling for a long time to get to 550 in your first screenshot. So it didn't seem intentional and I decided that the pattern length would be a more reasonable limit.

I do understand now how longer notes can be used, and have relaxed the limit in Bosca 3.1 which is now in development. But I still provide a cap at 128 units for the usability reasons provided above. If you have a really good case for notes beyond that, please let me know and we'll figure out a way to relax the limit further with some proper usability improvements (like, how would you like to comfortably get to 550 and then back to 1 unit).

If the limit of 128 seems reasonable to you as well, then we can close this as resolved.

i feel like this is the kind of thing that is fixed by changing a single value

It was not so trivial, unfortunately. With the setup that we have in Bosca 3.0 the limit can not go beyond 32, which made it easier to implement some aspects of exporters. To lift this limit I had to rewrite parts of exporters so they can work properly with arbitrary note lengths. (The aforementioned limit of 128 is arbitrary and only exists for better usability.)

in the arrangement timeline, the note doesn't end where its supposed to

Yes, there is a small problem with visuals. I haven't looked in detail how the old version handles this, but the problem starts with the fact that the pattern area on the timeline is split into two parts: the gutter with the pattern number and the note area. So the notes only take a fraction of the width of the bar. So each note's base size is not e.g. 1/16th of the whole bar, but 1/16th of the note area. So when they extend they also extend proportionally to that size, not the size of the whole bar.

You can see how this means that extending notes end way sooner.

This can be addressed with some cleverness, but it points at a bigger picture: the note area of the pattern doesn't align with the playback cursor/timeline. And that's by design (like it's literally what the visual design here is). I think the pattern block needs to be redesigned so notes are placed properly along the timeline, and then that problem resolves itself.

also in both versions, the line ceases to exist when the source block goes offscreen, which is a non-issue

Yeah, there is that too. I also consider this minor, but would be nice to address at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants