Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IsNfcRestricted needs to be invalidated #192

Open
1 task done
virot opened this issue Jan 26, 2025 · 1 comment
Open
1 task done

[BUG] IsNfcRestricted needs to be invalidated #192

virot opened this issue Jan 26, 2025 · 1 comment
Labels
awaiting yubico action When we've got the ball enhancement New feature or request known issue Used to indicate known issues by Yubico

Comments

@virot
Copy link

virot commented Jan 26, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

IsNfcRestricted cache is not invalidated efter SetIsNfcRestricted(true) is run.

Expected Behavior

The cache for IsNfcRestricted should be invalidated

Steps To Reproduce

var yubiKey = YubiKeyDevice.FindAll().First();
yubiKey.SetIsNfcRestricted(true);
yubiKey.IsNfcRestricted

https://github.com/virot/YubiKeyTests/blob/main/RestrictNFC/Program.cs

Image

Version

1.12.1

Version

5.7.1

Anything else?

No response

@virot virot added the bug Something isn't working label Jan 26, 2025
@virot virot changed the title [BUG] <title> [BUG] IsNfcRestricted needs to be invalidated Jan 26, 2025
@DennisDyallo
Copy link
Collaborator

Hi @virot
Yes, this is a known limitation of the SDK in the state it is in right now and I have myself found myself wanting this functionality. None of the properties behave in the way you ask, i.e. having the properties updated after the commands have been issued. The way it works now it simply issues the commands and doesn't update the YubiKeyDevice. One would have to reopen the connection (which reads the DeviceInfo anew). Having this done automatically would likely require a larger effort in the caching and the listeners.

As for priority, this will likely take a back seat to implementing the remaining 5.7 features. I bring it to our manager and circle back here to give you updates if any.

Thanks for your continued support in making the SDK great.

@DennisDyallo DennisDyallo added awaiting yubico action When we've got the ball known issue Used to indicate known issues by Yubico enhancement New feature or request and removed bug Something isn't working labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting yubico action When we've got the ball enhancement New feature or request known issue Used to indicate known issues by Yubico
Development

No branches or pull requests

2 participants