Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample problem results in unexpected keyword argument on current sklearn #19

Open
emunsing opened this issue Aug 1, 2023 · 0 comments
Open

Sample problem results in unexpected keyword argument on current sklearn #19

emunsing opened this issue Aug 1, 2023 · 0 comments

Comments

@emunsing
Copy link

emunsing commented Aug 1, 2023

Similar to #13 and likely for the same reason: When running the sample problem in README.md on python==3.9.17, sklearn==1.1.1, irf==0.2.5 I get TypeError: __init__() got an unexpected keyword argument 'min_impurity_split' rising from the call to initialize WeightedDecisionTreeClassifier.

I'm new to the codebase, but has there been discussion of abstracting away the calls to the predictor class to the extent possible to allow for better flexibility with sklearn version? Or specify sklearn version in requirements.txt?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@emunsing