Skip to content
This repository has been archived by the owner on Jul 15, 2019. It is now read-only.

Unused history check #106

Open
aocenas opened this issue Dec 1, 2015 · 1 comment
Open

Unused history check #106

aocenas opened this issue Dec 1, 2015 · 1 comment
Labels

Comments

@aocenas
Copy link

aocenas commented Dec 1, 2015

Hi, just noticed that this check: https://github.com/yahoo/fluxible-router/blob/master/lib/handleHistory.js#L41, is never changed to true. So I assume, that what ever it should prevent (creating more history listeners I think), it does not do that right now. Did not really check with any code samples, but simple search for that variable never turns any assignment which would change it to true.

@mridgway
Copy link
Collaborator

mridgway commented Dec 1, 2015

Good catch. That was put in place so that there aren't multiple handleHistory higher-order components on the page at once... but it seems somewhere along the line it was broken. This won't break anything since it's more of a development warning, but I'll take a look.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants