Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary custom printers and parsers from AIEVec ops #1894

Open
jsetoain opened this issue Oct 31, 2024 · 0 comments
Open

Remove unnecessary custom printers and parsers from AIEVec ops #1894

jsetoain opened this issue Oct 31, 2024 · 0 comments
Labels
good first issue Good for newcomers quality Improve code quality: maintainability, cleanup, code reorganization.

Comments

@jsetoain
Copy link
Collaborator

We have a number of AIEVec ops that, like ExtOp, PackOp, UnpackOp, or ShiftOp , use custom parsers and printers for no good reason. Moving to use the tablegen assemblyFormat field for those would be a good improvement to the code base.
@jsetoain jsetoain added good first issue Good for newcomers quality Improve code quality: maintainability, cleanup, code reorganization. labels Oct 31, 2024
@jsetoain jsetoain mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers quality Improve code quality: maintainability, cleanup, code reorganization.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsetoain