Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show album covers using YouTube Music #4

Closed
SeA-luby opened this issue Feb 4, 2023 · 8 comments
Closed

Show album covers using YouTube Music #4

SeA-luby opened this issue Feb 4, 2023 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@SeA-luby
Copy link

SeA-luby commented Feb 4, 2023

Hello, here are two features I'm eagerly looking forward to for this project.

  • It would be really cool to see the album cover instead of the YouTube Music icon.
  • When listening to YouTube music, all channel names end with '- Topic'. I would like this phrase to be removed.
@XFG16
Copy link
Owner

XFG16 commented Feb 4, 2023

Hey there SeA-luby!

Regarding your first point, that's something that I am unable to do. The reason for this is because any assets used as the icon for the rich presence must be uploaded and cached on Discord, for which there is a limited number of pictures available. In other words, it would be impossible to cover every single album cover for each artist. Discord does not allow for external internet sources (i.e. images from YouTube Music) to be displayed on the rich presence.

I can however add a feature to deal with your second point though! You can expect an update in the near future that addresses your point.

Thanks for taking the time to share your thoughts!

@XFG16 XFG16 added enhancement New feature or request and removed enhancement New feature or request labels Feb 4, 2023
@SeA-luby
Copy link
Author

SeA-luby commented Feb 5, 2023

I don't know how rich presence and this program works, but there is a way in the popular CustomRP app to specify a custom image via web links. The following is how I display a specific image in rich presence using an image link in CustomRP:

image

Wouldn't it be possible to apply such a function through a similar method? Thank you for your efforts.

@XFG16
Copy link
Owner

XFG16 commented Feb 5, 2023

You're exactly right!

In fact, I was tricked up by the documentation of the library I implemented, but you can indeed do something with external images. Originally, I believed that external image sources couldn't be used by the rich presence.

Thanks for the heads up! I'll see if I can implement your feature in the next update.

Stay tuned!

@XFG16 XFG16 self-assigned this Feb 5, 2023
@XFG16 XFG16 pinned this issue Feb 5, 2023
@XFG16
Copy link
Owner

XFG16 commented Feb 5, 2023

Something along the lines of this...?

@SeA-luby
Copy link
Author

SeA-luby commented Feb 5, 2023

Yes, that looks great!

@XFG16
Copy link
Owner

XFG16 commented Feb 5, 2023

Great!

I'll roll this out as a feature in the next update as soon as I have time.

Thank you for your time and contributions

@SeA-luby SeA-luby closed this as completed Feb 5, 2023
@XFG16
Copy link
Owner

XFG16 commented Feb 9, 2023

Hello! Just wanted to check in with you now that the update is out. Is everything working fine on your end after installing the new version?

@SeA-luby
Copy link
Author

Everything works fine! Thank you <3
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants