Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native support for promises? #15

Open
jung-kim opened this issue Apr 8, 2018 · 2 comments · May be fixed by #16
Open

Native support for promises? #15

jung-kim opened this issue Apr 8, 2018 · 2 comments · May be fixed by #16

Comments

@jung-kim
Copy link

jung-kim commented Apr 8, 2018

Would you guys accept PRs for a native support for promises or is it in works?

Or are you guys more fan of promise wrappers?
@stelcheck
Copy link
Member

I do not believe anything is currently in the work.

If support would be to be added, I'd prefer if we:

  1. Used native Promises.
  2. Made sure to remain backward compatible with the callback-based API (at least for now)

@ronkorving
Copy link
Collaborator

@jung-kim I think your request makes a lot of sense. We would have to establish how we can support both callback and Promise based APIs in an elegant way, but I for one am not against it. Do you have any suggestions as to what the API should look like, given that we also want to maintain backwards compatibility?

@jung-kim jung-kim linked a pull request Apr 10, 2018 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding initial promise end point jung-kim/locks
3 participants
@stelcheck @ronkorving @jung-kim