dependency_installer does not install needed packages

[spinkham]

Issue

dependency_installer does not install needed packages

Expected behaviour

Installs required packages

Actual behaviour

Does not install required packages. Installs only coreutils and coreutils-bin, and then exits, even when simple packages like awk and complex setups like theos are not yet installed.

Steps to reproduce

1. use dependency_installer
2. run

needle error logs

[needle][dependency_installer] > run
[] Checking connection with device...
[+] Already connected to: localhost
[D] Creating temp folder: /var/root/needle/
[D] [REMOTE CMD] Remote Command: if [ -d /var/root/needle/ ]; then echo "yes"; else echo "no" ; fi
[] Checking prerequisites...
[D] [REMOTE CMD] Remote Command: which apt-get
[D] [REMOTE CMD] Remote Command: which dpkg
[V] [INSTALL] Installing COREUTILS via apt-get.
[D] [REMOTE CMD] Remote Command: apt-get install -y --force-yes coreutils
[V] [INSTALL] Installing COREUTILS via apt-get.
[D] [REMOTE CMD] Remote Command: apt-get install -y --force-yes coreutils-bin
[D] [REMOTE CMD] Remote Command: apt-get update
[] Refreshing package list...
[D] [REMOTE CMD] Remote Command: dpkg --get-selections | grep -v "deinstall" | cut -f1
[D] [REMOTE CMD] Remote Command: apt-get update
[D] [REMOTE CMD] Remote Command: cat /etc/apt/sources.list.d/cydia.list
[] The following tools are going to be installed: []
[>][QUESTION] Do you want to continue? [y/N]: y
[needle][dependency_installer] >

Environment

Needle Version

• Framework (on your machine): Needle v1.3.2 (latest git 2018-02-05)
• Agent (on your device): v1.0.5

Workstation Operating System

MacOS 10.13.3

Python Version

2.7.10

Python Packages (pip freeze)

asn1crypto==0.24.0
backports-abc==0.5
bcrypt==3.1.4
biplist==1.0.3
certifi==2018.1.18
cffi==1.11.4
chardet==3.0.4
colorama==0.3.9
configparser==3.5.0
cryptography==2.1.4
Django==1.11.7
enum34==1.1.6
esptool==1.2.1
frida==10.6.50
idna==2.6
ipaddress==1.0.19
libxml2-python==2.9.7
lxml==4.1.1
numpy==1.13.3
paramiko==2.4.0
pdfkit==0.6.1
prompt-toolkit==1.0.15
protobuf==3.5.1
pyasn1==0.4.2
pycairo==1.15.5
pycparser==2.18
Pygments==2.2.0
PyNaCl==1.2.1
pyOpenSSL==17.5.0
pyqtgraph==0.10.0
pyserial==3.2.1
pytz==2017.3
pyxdg==0.25
QSpectrumAnalyzer==2.1.0
Qt.py==1.0.0
readline==6.2.4.1
requests==2.18.4
rsa==3.4.2
SimpleSoapy==1.5.1
SimpleSpectral==1.0.0
singledispatch==3.4.0.3
six==1.11.0
soapy-power==1.6.1
sshtunnel==0.1.3
tornado==4.5.3
urllib3==1.22
wcwidth==0.1.7

Device iOS Version

9.0.2

[marco-lancini]

Can you share your selected options for that module?

[whoot]

I gave it a try on iOS 11.1.2 with the default options:

Options:
  Name             Current Value  Required  Description
  ---------------  -------------  --------  -----------
  ALL              False          yes       Set to True to install all listed tools.
  CLASS-DUMP       False          yes       Set to True to install: CLASS-DUMP.
  CLUTCH           False          yes       Set to True to install: CLUTCH.
  COREUTILS        False          yes       Set to True to install: COREUTILS.
  CURL             False          yes       Set to True to install: CURL.
  CYCRIPT          False          yes       Set to True to install: CYCRIPT.
  DARWINTOOLS      False          yes       Set to True to install: DARWINTOOLS.
  FILEDP           False          yes       Set to True to install: FILEDP.
  FRIDA            False          yes       Set to True to install: FRIDA.
  FRIDA32BIT       False          yes       Set to True to install: FRIDA32BIT.
  FSMON            False          yes       Set to True to install: FSMON.
  GAWK             False          yes       Set to True to install: GAWK.
  GDB              False          yes       Set to True to install: GDB.
  KEYCHAIN_DUMP    False          yes       Set to True to install: KEYCHAIN_DUMP.
  ONDEVICECONSOLE  False          yes       Set to True to install: ONDEVICECONSOLE.
  OPEN             False          yes       Set to True to install: OPEN.
  PBWATCHER        False          yes       Set to True to install: PBWATCHER.
  PERL             False          yes       Set to True to install: PERL.
  PLUTIL           False          yes       Set to True to install: PLUTIL.
  SCP              False          yes       Set to True to install: SCP.
  THEOS            False          yes       Set to True to install: THEOS.
  UNZIP            False          yes       Set to True to install: UNZIP.

Output was:

[needle][dependency_installer] > run
[*] Checking connection with device...
[+] Already connected to: 192.168.178.51
[*] Checking prerequisites...
[V] [INSTALL] Installing COREUTILS via apt-get.
[!] W: --force-yes is deprecated, use one of the options starting with --allow instead.

[V] [SSH] Disconnecting...
[V] [AGENT] Disconnecting from agent...
[?] Resetting connection to device...
[V] [AGENT] Connecting to agent (192.168.178.51:4444)...
[+] [AGENT] Successfully connected to agent (192.168.178.51:4444)...
[V] [SSH] Connecting (192.168.178.51:22)...
[+] [SSH] Connected (192.168.178.51:22)
[?] Rerunning last command...
[!] W: --force-yes is deprecated, use one of the options starting with --allow instead.

[V] [SSH] Disconnecting...
[V] [AGENT] Disconnecting from agent...
[?] Resetting connection to device...
[V] [AGENT] Connecting to agent (192.168.178.51:4444)...
[+] [AGENT] Successfully connected to agent (192.168.178.51:4444)...
[V] [SSH] Connecting (192.168.178.51:22)...
[+] [SSH] Connected (192.168.178.51:22)
[?] Rerunning last command...
[?] Error occurred during installation of tools: An error occurred and it was not possible to restore it (3 attempts failed)
[?] Trying to continue anyway...
[!] W: No sandbox user '_apt' on the system, can not drop privileges
W: Invalid 'Date' entry in Release file /var/lib/apt/lists/mobiletools.mwrinfosecurity.com_cydia_._Release
W: Invalid 'Date' entry in Release file /var/lib/apt/lists/repounclutter.coolstar.org_._Release
W: Invalid 'Date' entry in Release file /var/lib/apt/lists/repo.dynastic.co_._Release
W: Invalid 'Date' entry in Release file /var/lib/apt/lists/electrarepo64.coolstar.org_._Release
W: Invalid 'Date' entry in Release file /var/lib/apt/lists/repo.chariz.io_._Release