Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Popup Misaligned When Cursor Is Beyond First 'Page' #151

Closed
Eldenroot opened this issue Sep 13, 2017 · 16 comments
Closed

Autocomplete: Popup Misaligned When Cursor Is Beyond First 'Page' #151

Eldenroot opened this issue Sep 13, 2017 · 16 comments
Assignees
Milestone

Comments

@Eldenroot
Copy link
Contributor

Eldenroot commented Sep 13, 2017

Rin editor + latest maintenance version (13.9.2017) - > go to the full edit of your post and type "@", popup menu is misaligned (Google Chrome) + (again, check the usernames and avatars -> they are again assigned randomly, #139 )

bug7

@WildcardSearch
Copy link
Owner

I need to update my copy of Rin Editor and do some testing. Thanks again.

@Eldenroot
Copy link
Contributor Author

I use latest version on my board (feel free to test it).

@WildcardSearch
Copy link
Owner

@Cu8eeeR I can't reproduce that error with Chrome 61-- what version are you using?

screen shot

@Eldenroot
Copy link
Contributor Author

Eldenroot commented Sep 16, 2017

Please try to edit any post with a lot of text... .)

P.S. As you can see, the avatars are wrongly assigned - "ZH6" user has avatar from "šmoula" :(

@WildcardSearch
Copy link
Owner

Please try to edit any post with a lot of text... .)

Okay, will do.

P.S. As you can see, the avatars are wrongly assigned - "ZH6" user has avatar from "šmoula" :(

I understand. Please be patient, I am still testing. It is a little harder for me because I don't know which name goes with each avatar so I have to check profiles.

@Eldenroot
Copy link
Contributor Author

Eldenroot commented Sep 16, 2017

I understand. Please be patient, I am still testing. It is a little harder for me because I don't know which name goes with each avatar so I have to check profiles.

I am sorry, it was only a notice that the bug is not related only to my browser :( Keep good work, I am looking forward! Great support!

Okay, will do.

Works fine for "short" posts, but with a large amount of text the position of the popup window is bad :(

@WildcardSearch
Copy link
Owner

I will try to see if I can sort that out. Meanwhile I have found another bug... '(

@WildcardSearch WildcardSearch changed the title Full edit - misaligned popup window Autocomplete: Popup Misaligned When Cursor Is Beyond First 'Page' Sep 16, 2017
@WildcardSearch WildcardSearch self-assigned this Sep 16, 2017
@WildcardSearch WildcardSearch added this to the 3.1.2 milestone Sep 16, 2017
@WildcardSearch
Copy link
Owner

Confirmed. I'll try to get this sorted today or tomorrow.

@WildcardSearch
Copy link
Owner

This issue actually affects Quick Reply as well when using Rin Editor.

@WildcardSearch
Copy link
Owner

This is caused by a bug in Caret.js, the third part library I am using for cursor positioning: ichord/Caret.js#56

I'm going to have to come up with a workaround because the project appears to be dying/dead-- no updates in two years...

WildcardSearch pushed a commit that referenced this issue Sep 17, 2017
...where a bug the third party library, Caret.js, caused the popup to be
incorrectly positioned.
@WildcardSearch
Copy link
Owner

This fixes the issue for me. Still testing to ensure that these changes don't break anything else.

@Eldenroot
Copy link
Contributor Author

@WildcardSearch - I updated my board to your latest maintenance release. Your commit fixes this issue partially - when you scroll during the full edit and use "@" to mention someone -> popup position is miss aligned :( Anyway if you dont scroll over the post, the position is OK (it was bugged before, now works fine). I think it is enough, works fine, thank you very much!

P.S. Here you can test it - https://www.carcassonneforum.cz/thread-948-post-10239.html#pid10239

Thank you very much, one bug less :) Good job!

@WildcardSearch
Copy link
Owner

WildcardSearch commented Sep 17, 2017

I'm sorry, but I'm having a hard time understanding the problem that you are saying still exists. Can you give me simple steps to reproduce?

Thank you very much, one bug less :) Good job!

I appreciate it. Thanks for putting up with all the delays.

@Eldenroot
Copy link
Contributor Author

I'm sorry, but I'm having a hard tim understanding the problem that you are saying still exists. Can you give me simple steps to reproduce?

I will try to make a video if I find any free time.

I will try to describe this issue again:

  1. Go to -> New thread/new post/full edit
  2. Press "@" -> popup menu is displayed (5 or more users needed)
  3. Try to move in the list with usernames switch with keyboard arrows (down)
  4. Selected username is always the first one in the list (on the top of the list). It would be better to do not scroll (sort) the usernames during the moving within the list by arrows and move the selected usernames to the top of the list.

I hope it is better to understand :(

@WildcardSearch
Copy link
Owner

Oh, so you are just talking about #158 ?

@Eldenroot
Copy link
Contributor Author

@WildcardSearch - I am so sorry, bad ticket (need to go sleep, it is 11PM here) :(

I will try to describe it again in the right ticket :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants