From fe4005dfa435ca88ed0a736f0c6a8bce748c65c3 Mon Sep 17 00:00:00 2001 From: Wenjie Du Date: Wed, 17 Apr 2024 23:33:26 +0800 Subject: [PATCH 1/2] fix: avoid the import error MessagePassing not defined when torch_geometric not installed; --- pypots/nn/modules/raindrop/__init__.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/pypots/nn/modules/raindrop/__init__.py b/pypots/nn/modules/raindrop/__init__.py index 47d9da1b..c8aec3ee 100644 --- a/pypots/nn/modules/raindrop/__init__.py +++ b/pypots/nn/modules/raindrop/__init__.py @@ -13,9 +13,7 @@ # License: BSD-3-Clause from .backbone import BackboneRaindrop -from .layers import ObservationPropagation __all__ = [ "BackboneRaindrop", - "ObservationPropagation", ] From ec8bee3495ff2e4588245ad310d86834477c65d5 Mon Sep 17 00:00:00 2001 From: Wenjie Du Date: Wed, 17 Apr 2024 23:55:25 +0800 Subject: [PATCH 2/2] Test building package during CI (#353) * test: test building without torch-geometric during CI; --- .github/workflows/testing_ci.yml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/workflows/testing_ci.yml b/.github/workflows/testing_ci.yml index e73458e8..10572236 100644 --- a/.github/workflows/testing_ci.yml +++ b/.github/workflows/testing_ci.yml @@ -55,6 +55,15 @@ jobs: - name: Install other dependencies run: | pip install -r requirements.txt + + - name: Test building package + # we need to know if the package can be built successfully without optional dependencies + run: | + pip install build wheel + python -m build --no-isolation + + - name: Continue to install torch-geometric dependencies + run: | pip install torch-geometric torch-scatter torch-sparse -f "https://data.pyg.org/whl/torch-${{ steps.determine_pytorch_ver.outputs.value }}+cpu.html" pip install pypots[dev] python_site_path=`python -c "import site; print(site.getsitepackages()[0])"`