Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use existing secret for config #5

Open
MPV opened this issue May 12, 2020 · 5 comments
Open

Ability to use existing secret for config #5

MPV opened this issue May 12, 2020 · 5 comments
Labels
enhancement Adding or requesting a new feature.

Comments

@MPV
Copy link

MPV commented May 12, 2020

Hi,
This looks promising!

I see you already support setting some "secret" environment variables via values.

In my case, I'd like to be able to configure these and additional environment variables, for example:

GITHUB_TOKEN
WEBLATE_AUTH_LDAP_SERVER_URI

I would also like to do this without needing to put them in my values.yaml file.

...for example by adding a secret beforehand and configuring this chart to use my predefined secret instead of creating a new one.

As this chart is using postgres, here's an example of how the postgres chart either creates a secret or uses an existing one:
https://github.com/helm/charts/blob/12a061a/stable/postgresql/templates/_helpers.tpl#L210-L232

What do you think, would you be open to supporting something like this?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@tarioch
Copy link
Contributor

tarioch commented May 12, 2020

Sure, can you create a PR for it?

The existing secret should be simple, for having additional values from the secret, might make sense to add something similar to the extraConfig that would loop over arbitrary values. Maybe an extraSecretConfig?

@MPV
Copy link
Author

MPV commented May 14, 2020

Sorry, it looks like I'll be giving Hosted Weblate a try first.
If that doesn't fulfill our needs, I might come back here and help out some more. 😊

@stale
Copy link

stale bot commented May 31, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix Nobody will work on this. label May 31, 2020
@nijel nijel added enhancement Adding or requesting a new feature. and removed wontfix Nobody will work on this. labels May 31, 2020
@eestolano
Copy link

Does the extraSecretName in the Helm chart solve this issue?

@gllb
Copy link
Contributor

gllb commented Sep 15, 2022

externalSecretName seems to not override existing secrets, so there is no possibility to control for exemple the REDIS_PASSWORD if we deploy redis with this chart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants