Incompatible changes break upgrade

[pmhahn]

Describe the issue

Currently I'm running 4.14.2 and trying to upgrade to 4.14.latest, which fails.

First error is this

$ helm upgrade -n weblate weblate weblate/weblate -f values.yaml
Error: UPGRADE FAILED: execution error at (weblate/charts/postgresql/templates/secrets.yaml:17:24): 
PASSWORDS ERROR: The secret "weblate-postgresql" does not contain the key "postgres-password"

After duplicating the old entry postgresql-passwort to postgres-password using kubectl -n weblate edit secret/weblate-postgresql I now get the next error (reformatted for readability):

$ helm upgrade -n weblate weblate weblate/weblate -f values.yaml
Error: UPGRADE FAILED:
cannot patch "weblate-postgresql" with kind StatefulSet: StatefulSet.apps "weblate-postgresql" is invalid: spec:
  Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden
&&
cannot patch "weblate-redis-master" with kind StatefulSet: StatefulSet.apps "weblate-redis-master" is invalid: spec:
  Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

I already tried

• I've read and searched the documentation.
• I've searched for similar issues in this repository.

Steps to reproduce the behavior

1. helm upgrade -n weblate weblate weblate/weblate -f values.yaml

Expected behavior

helm upgrading Weblate

Screenshots

No response

Exception traceback

$ helm upgrade -n weblate weblate weblate/weblate -f values.yaml --debug
…
client.go:250: [debug] error updating the resource "weblate-postgresql":
         cannot patch "weblate-postgresql" with kind StatefulSet: StatefulSet.apps "weblate-postgresql" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden
client.go:510: [debug] Patch StatefulSet "weblate-redis-master" in namespace weblate
client.go:250: [debug] error updating the resource "weblate-redis-master":
         cannot patch "weblate-redis-master" with kind StatefulSet: StatefulSet.apps "weblate-redis-master" is invalid: spec: Forbidden: updates to statefulset spec for fields other than 'replicas', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

$ helm upgrade -n weblate weblate weblate/weblate -f values.yaml --debug --dry-run
…

### Additional context

_No response_

[nijel]

Might be result of PostgreSQL upgrade in #195, that has changed quite some things...

[github-actions]

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

[mosesdd]

this is still an issue

[github-actions]

This issue has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

[WolfspiritM]

I'm running 0.4.14 and thought it's a good idea to upgrade to the latest patch release 0.4.24.
I even checked https://github.com/WeblateOrg/helm/releases for breaking changes but none were reported.
I couldn't find a changelog for this helm chart.

After upgrade the postgresql database doesn't come online anymore cause the versions aren't compatible.

Luckily I was able to revert back to the old version.

It would really be nice if you introduce breaking changes that you could update to a new minor (or even better major) version and provide breaking changes in the release notes and even provide an upgrade path if possible.

[nijel]

Yes, this chart really needs a maintainer who understands Kubernetes. Right now, it's me merging changes, but I know Weblate and not Kubernetes, so it's easy to merge something that breaks things without noticing.

[nijel]

I'm looking for reviews of #317 to avoid further breakages of the chart.

[f3k-freek]

Are there any updates on this issue? Or are there upgrade instructions?

[nijel]

There have been several fixes to the chart meanwhile, but I don't think this issue has been fully addressed (IMHO that would break the current setups). If you have any suggestions how to improve the chart, pull requests are welcome. See also #348.