Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit module definition or module instance unless present in input when generating .bin.wast #1811

Open
titzer opened this issue Sep 23, 2024 · 2 comments

Comments

@titzer
Copy link
Contributor

titzer commented Sep 23, 2024

The PR #1796 changed the reference interpreter to generate these new commands by default in arrange.ml. Unfortunately this breaks downstream clients that consume .bin.wast.

Would it be possible to only emit module definition and module instance if they were in the original source?

@rossberg
Copy link
Member

rossberg commented Sep 24, 2024

I'll look into it. It might be non-trivial, since the old form is desugared in the parser already.

Edit: Won't these clients have to be adapted anyway? Otherwise they won't be able to run all tests either way.

@titzer
Copy link
Contributor Author

titzer commented Sep 24, 2024

Ok, thanks for taking a look. If it's nontrivial work, don't waste too much time on it.

Won't these clients have to be adapted anyway? Otherwise they won't be able to run all tests either way.

Yes, eventually, when tests start using the new feature. I just hit this because I was writing tests for the stack-switching proposal which recently had this change integrated, and thus Wizard couldn't run my new tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants