Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bikeshed) Should we rename the parameters for Table.get and Table.set? #93

Open
bvisness opened this issue Oct 22, 2024 · 1 comment
Open

Comments

@bvisness
Copy link
Collaborator

bvisness commented Oct 22, 2024

@backes points out in this comment that perhaps we should rename the index parameter on Table.get and Table.set to address as a result of #67. I'm not sure we want to, since the existing spec already uses the term "index" and it's quite clear in context that it's referring to the index of an element. Thoughts? (This certainly does not need to block phase 4 vote imo. Just wanted to discuss it before it all ends up on MDN and wherever else.)

@backes
Copy link
Member

backes commented Oct 23, 2024

It's obviously not super critical, but while we change the type from unsigned long to AddressValue I would prefer to also just rename index to address, for consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants