Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GlobalToken instead of ThemeConfig #2

Open
Kamahl19 opened this issue Jan 23, 2023 · 0 comments
Open

Use GlobalToken instead of ThemeConfig #2

Kamahl19 opened this issue Jan 23, 2023 · 0 comments

Comments

@Kamahl19
Copy link

Kamahl19 commented Jan 23, 2023 •
edited
Loading

Shouldn't the Emotion theme type be extended with GlobalToken https://github.com/ant-design/ant-design/blob/1f657398a33aa197d1c85f1f89bd337aaf7f2a47/components/theme/interface/index.ts#L9 instead of ThemeConfig ? Token returned from antTheme.useToken() is of type GlobalToken and has a different shape (e.g. components inlined with tokens)

antd-emotion-dynamic-theme/src/theme/types.d.ts

Line 4 in ec62bf8

export interface Theme extends ThemeConfig {} 

  export interface Theme {
    token: GlobalToken;
  }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Kamahl19