-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve consistency of python and binary logging #4186
Comments
Ideally, Python could hook into the structured logs that VW produces and forward them to the standard Python logging infrastructure. Then the user can filter or consume as need be |
Hey @ataymano, I tried reproducing this issue with vw v9.0.0+
train.dat
Python command
output:
CLI Command
output:
According to my observed output, the difference between Python and CLI is in "cb_type", "Enabled reductions", "Input label" and "Output pred". I tried to take a look at pylibvw.cc to understand how the logging wrapper is setup but I'm really confused. It states "do not use vw_log". However, Any insights on this? |
@jackgerrits Isn't this what's currently happening with the py_log_wrapper class? |
I implemented my take on this feature in the new set of python bindings (https://github.com/VowpalWabbit/py-vowpal-wabbit-next/blob/f5727409f9674168e7468865aa83b7e6ba8cdccd/src/main.cpp#L266). Essentially any internal log in VW is forwarded to Python's |
Short description
There are mismatches in how python and vw binary logs are working:
cmd:
python:
How this suggestion will help you/others
Given 2 and 3 there are messages that are impossible to see from python (explore_eval/audit/etc)
Possible solution/implementation details
Maybe python get_log() method can be replaced with either get_stdout/get_stderr or get_driver/get_logs pairs?
The text was updated successfully, but these errors were encountered: