Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info button in legend opens widget instead of info panel #1080

Open
lhilarides opened this issue Mar 25, 2024 · 4 comments
Open

Info button in legend opens widget instead of info panel #1080

lhilarides opened this issue Mar 25, 2024 · 4 comments
Labels
QC Quality check (client revision)

Comments

@lhilarides
Copy link
Collaborator

The information button for each layer in the legend (1) open the layer's widget (2) instead of opening the information panel of the layer

image

@mluena
Copy link
Collaborator

mluena commented Apr 24, 2024

This wasn't exactly a bug, but a design choice. With the new layout, we've enabled the layer to remain active even when the widget is hidden. To ensure easy access to all features, I've added a dialog with layer details in the info icon, and another dialog for the widget under its title, let me know if you are happy with this approach

@mluena mluena added the QC Quality check (client revision) label Apr 24, 2024
@klongleywood
Copy link

This looks ok to me

@klongleywood
Copy link

@lhilarides can you weigh in on this one?

@lhilarides
Copy link
Collaborator Author

For now it's OK because the info button does what's expected, which was the main point and I also find the additional functionality useful to be able to bring the widget to the foreground quickly, especially when in full-screen mode.

However...

  1. if the widget is already active, you have duplicates which doesn't look great, and
  2. users won't easily discover they can click on the title in the legend to bring up the widget

Altogether I think just leave it as it is for now but for the next iteration, we could consider adding a "widget on/off" button to the legend, similar to the "layer on/off" button we have on the widgets. This button would then simply enable/disable the widget instead of showing a copy in a pop-up, which I think would give a more intuitive UX

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QC Quality check (client revision)
Projects
None yet
Development

No branches or pull requests

3 participants