Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading from 1.21.1->1.21.3 server breaks custom item compatibility #938

Open
4 tasks done
Kichura opened this issue Dec 18, 2024 · 3 comments
Open
4 tasks done

Comments

@Kichura
Copy link
Member

Kichura commented Dec 18, 2024

'/viaversion dump' Output

https://dump.viaversion.com/abfdbbd2a1b1a2e90948a52eaa0fa100a7e2f1c1360d47f8f9f1429696e7370c

Server/Client Error

[Render thread/WARN]: Client disconnected with reason: Internal Exception: io.netty.handler.codec.DecoderException: Failed to decode packet 'clientbound/minecraft:container_set_content'

Bug Description

When creating a custom item through ItemEdit and/or ItemTag with latin or other characters such as ■ ᴀ ʙ and then upgrading paper from 1.21.1 to 1.21.3 causes player to be permanently kicked once inventory is opened.

Steps to Reproduce

  1. Create a Paper 1.21.1 server,
  2. Install Latest crazyenchantments, itemtag and itemedit,
  3. Install latest Via* from CI,
  4. Log on to the server using 1.21.1 server as operator,
  5. Apply random lore using specific characters such as latin and whatnot, (and optionally random enchants)
  6. Shutdown server and switch it over to 1.21.3,
  7. Attempt to log in again,
  8. Client should get kicked off.

Expected Behavior

Custom items do not kick players from the server upon attempting to enter.

Additional Server Info

  1. This server does not have any proxies active,
  2. Paper 1.21.1-132 for first run then Paper 1.21.3-81 for second run,
  3. Plugins were CrazyEnchantments (2.5.1), ItemEdit (3.5.5), ItemTag (3.5.1) and both VB+VV 5.2.1-SNAPSHOT.

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried a build from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Dec 18, 2024

Platform: 1.21.3--81--da71382%20%28MC%3A%201.21.3%29
ViaVersion (5.2.1-SNAPSHOT): Even with master
ViaBackwards(5.2.1-SNAPSHOT): Even with master

@FlorianMichael
Copy link
Member

Can you provide server or client logs with possible errors?

@Kichura
Copy link
Member Author

Kichura commented Dec 20, 2024

Can you provide server or client logs with possible errors?

The client only gave me the container error, meanwhile server showed nothing when i ran this test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants