Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor suggestions #1

Open
markus-i opened this issue Feb 19, 2019 · 0 comments
Open

Two minor suggestions #1

markus-i opened this issue Feb 19, 2019 · 0 comments

Comments

@markus-i
Copy link

markus-i commented Feb 19, 2019

Hi,

I had a (very short) look at the code, since I am (and have been - like may others) working on a similar (non-commercial) project, and I found two small things that could be (IMO) improved:

    • using pool.ntp.org as NTP server name should assign you a random server from the NTP pool instead of forcing people to Google
  • Jack Christensen's Timezone library https://github.com/JChristensen/Timezone would let you automate the DST switching:

// *************************** time change rule stuff **********************************//
//Central European Time (Frankfurt, Paris)
TimeChangeRule CEST = {"CEST", Last, Sun, Mar, 2, 120}; //Central European Summer Time
TimeChangeRule CET = {"CET ", Last, Sun, Oct, 3, 60}; //Central European Standard Time
Timezone CE(CEST, CET);
TimeChangeRule *tcr; // pointer to the time change rule, use to get TZ abbrev
// *************************** time change rule stuff **********************************//

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant