Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scramble parser should return Result #61

Open
stanleydesu opened this issue Oct 20, 2021 · 1 comment
Open

Scramble parser should return Result #61

stanleydesu opened this issue Oct 20, 2021 · 1 comment
Assignees
@V-Wong
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@stanleydesu
Copy link
Collaborator

CubeSimRS/src/scramble_parser.rs

Line 47 in 92ffac3

panic!()

Should return Result instead of panicking, as the user can handle the error better.
@V-Wong
Copy link
Owner

V-Wong commented Oct 20, 2021

Agree, will make change.

@V-Wong V-Wong added enhancement New feature or request good first issue Good for newcomers labels Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@V-Wong V-Wong

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stanleydesu @V-Wong