Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaper: Start without S3 access key #1248

Open
3 tasks
LtChae opened this issue May 27, 2021 · 1 comment
Open
3 tasks

Reaper: Start without S3 access key #1248

LtChae opened this issue May 27, 2021 · 1 comment

Comments

@LtChae
Copy link
Contributor

LtChae commented May 27, 2021

What?

Allow Reaper to start up with access to Vault but no S3 credentials

  • Reaper does not crash on startup if it cannot retrieve S3 credentials from vault
  • Reaper is still able to retrieve dataset secrets from Vault

Technical Notes:

  • Reaper will already bypass getting S3 credentials if it does not have a secrets endpoint, but this disables dataset secret retrieval as well

Why?

Starting a new pipeline from scratch does not require Reaper to immediately have all its capabilities. Hosted datasets are rare in the current instance, and might not be needed for new instances. Adding S3 credentials to Vault is a manual process that can be avoided.

@ksmith-accenture ksmith-accenture added dev On Hold Assigned to cards who were originally under the column titled 'On Hold' and removed On Hold Assigned to cards who were originally under the column titled 'On Hold' labels Jul 9, 2021
@jessicapfoster
Copy link

This is less important now because s3 access keys are a part of the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants